fix: hide ExperimentalWarning
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Sep 14, 2023
| @@ -1,3 +1,5 @@ | |||
| #!/usr/bin/env node | |||
| #!/usr/bin/env NODE_OPTIONS=--no-warnings node | |||
There was a problem hiding this comment.
Does that other process.env.NODE_NO_WARNINGS = 1; solution work too? I'm not sure which one is cleaner.
kanadgupta
pushed a commit
that referenced
this pull request
Sep 14, 2023
# [9.0.0-next.2](v9.0.0-next.1...v9.0.0-next.2) (2023-09-14) ### Bug Fixes * hide `ExperimentalWarning` ([#901](#901)) ([f9b5679](f9b5679)) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
As I feared, the current version in
nextyields this whenever you run anrdmeCLI command:This was surprisingly not straightforward (it was buried in the comments: nodejs/node#10802 (comment)) and I don't love this solution, but I confirmed that adding a
NODE_OPTIONSenv variable to the entry shebang should fix this.🧬 QA & Testing
I
npm link'd locally and confirmed the warning goes away: